[webkit-reviews] review granted: [Bug 109553] Web Inspector: Introduce version controller to migrate settings versions. : [Attachment 187799] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 109553: Web Inspector: Introduce version controller to migrate settings
versions.
https://bugs.webkit.org/show_bug.cgi?id=109553

Attachment 187799: Patch
https://bugs.webkit.org/attachment.cgi?id=187799&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187799&action=review


> Source/WebCore/inspector/front-end/Settings.js:352
> +WebInspector.VersionController = function()

Maybe WebInspector.Settings.VersionController ?

> LayoutTests/inspector/version-controller.html:6
> +{setTimeout(InspectorTest.completeTest.bind(InspectorTest), 1000);

Wrong alignment. Why do we need this timeout at all?