[webkit-reviews] review granted: [Bug 109284] Web Inspector: for event listener provide handler function value in protocol and in UI : [Attachment 187641] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 109284: Web Inspector: for event listener provide handler function value in
protocol and in UI
https://bugs.webkit.org/show_bug.cgi?id=109284

Attachment 187641: Patch
https://bugs.webkit.org/attachment.cgi?id=187641&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187641&action=review


> Source/WebCore/inspector/Inspector.json:1759
> +		       { "name": "handler", "$ref": "Runtime.RemoteObject",
"optional": true, "description": "Event handler function value" }

Missing . at the end of the sentence.

> Source/WebCore/inspector/InspectorDOMAgent.h:134
> +    virtual void getEventListenersForNode(ErrorString*, int nodeId, const
WTF::String*, RefPtr<TypeBuilder::Array<TypeBuilder::DOM::EventListener> >&
listenersArray);

Param name would make sense here, otherwise it is hard to guess that the string
param is objectGroupId