[webkit-reviews] review denied: [Bug 109488] Web Inspector: fix closure compilation warnings caused by setVariableValue change : [Attachment 187676] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied  review:
Bug 109488: Web Inspector: fix closure compilation warnings caused by
setVariableValue change
https://bugs.webkit.org/show_bug.cgi?id=109488

Attachment 187676: Patch
https://bugs.webkit.org/attachment.cgi?id=187676&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
The patch introduces new warnings:

Compiling InjectedScriptSource.js...
Source/WebCore/inspector/InjectedScriptSourceTmp.js:609: WARNING - actual
parameter 2 of InjectedScript.prototype._callFrameForId does not match formal
parameter
found	: (boolean|string)
required: string
	    var callFrame = this._callFrameForId(topCallFrame, callFrameId);
							       ^

Source/WebCore/inspector/InjectedScriptSourceTmp.js:614: WARNING - actual
parameter 1 of InjectedScript.prototype._parseObjectId does not match formal
parameter
found	: (boolean|string)
required: string
	    var parsedFunctionId = this._parseObjectId(functionObjectId);
						       ^

0 error(s), 2 warning(s), 89.8% typed