[webkit-reviews] review granted: [Bug 109402] Web Inspector: JavaScript execution disabled by browser/UA should be notified to the front-end : [Attachment 187524] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vivek Galatage
<vivekg at webkit.org>'s request for review:
Bug 109402: Web Inspector: JavaScript execution disabled by browser/UA should
be notified to the front-end
https://bugs.webkit.org/show_bug.cgi?id=109402

Attachment 187524: Patch
https://bugs.webkit.org/attachment.cgi?id=187524&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187524&action=review


> Source/WebCore/inspector/InspectorPageAgent.cpp:340
> +    , m_enabledScriptsEnabledNotification(true)

The name sounds a bit awkward, maybe rename it to something like
m_ignoreScriptsEnabledNotification?

> Source/WebCore/inspector/InspectorPageAgent.cpp:1038
> +    if (!m_frontend || !m_enabledScriptsEnabledNotification)

You don't need to check for m_frontend since control flow reaches this method
iff there is a front-end and the agent is enabled.