[webkit-reviews] review denied: [Bug 109060] Use GL typedefs in WebGLRenderingContext.idl : [Attachment 187070] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 21:42:19 PST 2013


Kenneth Russell <kbr at google.com> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 109060: Use GL typedefs in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=109060

Attachment 187070: Patch
https://bugs.webkit.org/attachment.cgi?id=187070&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187070&action=review


This will be great -- really looking forward to seeing this go in. The patch
looks good overall. However, the patch for bug 52340, which this depends on,
still has issues to be resolved, and has to land before the early warning
system bots can properly process this patch. I'm marking this r- because it
can't be properly reviewed yet. Please resubmit this patch and request review
when the fix for bug 52340 has landed.

> Source/WebCore/ChangeLog:16
>	   Look into possibilities of typedef in webkit idl files

The ChangeLog will need to be regenerated after the fix for bug 52340 lands.


More information about the webkit-reviews mailing list