[webkit-reviews] review denied: [Bug 109166] [V8] Call V8::AdjustAmountOfExternalAllocatedMemory() in sync with updating SerialziedScriptValue::m_data : [Attachment 187042] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 109166: [V8] Call V8::AdjustAmountOfExternalAllocatedMemory() in sync with
updating SerialziedScriptValue::m_data
https://bugs.webkit.org/show_bug.cgi?id=109166

Attachment 187042: Patch
https://bugs.webkit.org/attachment.cgi?id=187042&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Sorry for the delay reviewing this. I must be missing something because neither
the previous code nor the new code look correct. I probably r+'d the earlier
bad patch and apologize for that. It looks like m_data is a string representing
the serialized object graph, but the whole point of transferring ArrayBuffers
is that their contents aren't serialized -- they're transferred from one
isolate to another. The amount of external allocated memory needs to be the sum
of the transferred ArrayBuffers' sizes, not the size of the m_data string. I'm
not sure exactly how and where this should be computed.