[webkit-reviews] review granted: [Bug 109370] [chromium] Apply page scale to all WebInputEvent types : [Attachment 187736] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 18:02:30 PST 2013

James Robinson <jamesr at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 109370: [chromium] Apply page scale to all WebInputEvent types

Attachment 187736: Patch

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187736&action=review

R=me, one question for your consideration

> Source/WebKit/chromium/src/WebInputEventConversion.cpp:178
> +	   m_area = IntSize(e.data.tap.width / scale, e.data.tap.height /

do we want to use an explicit conversion here so we know what sort of rounding
we're getting?	Maybe go to a FloatSize first and then use

More information about the webkit-reviews mailing list