[webkit-reviews] review granted: [Bug 109476] REGRESSION(r136967): Combination of float and clear yields to bad layout : [Attachment 187662] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 109476: REGRESSION(r136967): Combination of float and clear yields to bad
layout
https://bugs.webkit.org/show_bug.cgi?id=109476

Attachment 187662: Patch
https://bugs.webkit.org/attachment.cgi?id=187662&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187662&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2284
>	       // The top margin edge of a self-collapsing block that clears a
float intrudes up into it by the height of the margin,
>	       // so in order to place this child float at the top content edge
of the self-collapsing block add the margin back in before placement.

It may be worthwhile updating the comment since it's here. "in order to place
the first child"