[webkit-reviews] review granted: [Bug 109334] Harden FastMalloc (again) : [Attachment 187692] Patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 109334: Harden FastMalloc (again)
https://bugs.webkit.org/show_bug.cgi?id=109334

Attachment 187692: Patch
https://bugs.webkit.org/attachment.cgi?id=187692&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187692&action=review


r=me with comments.

> Source/WTF/ChangeLog:17
> +	   I've also made an explicit struct type forthe FastMalloc singly
linked

for the

> Source/WTF/wtf/FastMalloc.cpp:695
> +// Hardened singly linked list.  We make this a struct to allow compiler to

s/struct/class

> Source/WTF/wtf/FastMalloc.cpp:4549
> +    ASSERT(localAddress);
> +    if (!localAddress)
> +	   return 0;

We didn't ASSERT in the old code. Are you sure this is okay?