[webkit-reviews] review granted: [Bug 109466] [Mac] Track language selection should be sticky : [Attachment 187671] Export Page::initGroup.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 14:30:43 PST 2013


Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 109466: [Mac] Track language selection should be sticky
https://bugs.webkit.org/show_bug.cgi?id=109466

Attachment 187671: Export Page::initGroup.
https://bugs.webkit.org/attachment.cgi?id=187671&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187671&action=review


> Source/autotools/symbols.filter:269
> +_ZN7WebCore9PageGroup18captionPreferencesEv;
> +_ZN7WebCore4Page9initGroupEv;

You don't need to guard these with VIDEO_TRACK like in exp.in?

> LayoutTests/media/track/track-user-preferences.html:117
> +		       createTrackElements([ 'no', 'fr', 'en',]);

trailing comma

> LayoutTests/media/track/track-user-preferences.html:127
> +		       createTrackElements([ 'ru', 'jp', 'en',]);

trailing comma


More information about the webkit-reviews mailing list