[webkit-reviews] review granted: [Bug 105348] XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary : [Attachment 187607] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 11 14:24:45 PST 2013
Alexey Proskuryakov <ap at webkit.org> has granted Yong Li <yoli at rim.com>'s
request for review:
Bug 105348: XMLHttpRequestProgressEventThrottle::resume() always schedules
timer even when unnecessary
https://bugs.webkit.org/show_bug.cgi?id=105348
Attachment 187607: the patch
https://bugs.webkit.org/attachment.cgi?id=187607&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187607&action=review
Looks right to me.
> Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp:202
> + // There is no deferred event. Let's clear the flag now.
I don't think that this comment is useful. It just describes what the code
does.
Please remove the comment before landing.
More information about the webkit-reviews
mailing list