[webkit-reviews] review denied: [Bug 109456] [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit : [Attachment 187615] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 13:24:51 PST 2013

Benjamin Poulain <benjamin at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 109456: [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit

Attachment 187615: patch

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187615&action=review

> Source/WebKit2/ChangeLog:8
> +	   WebView dtor now consideres the situation if its WebPageProxy


> Source/WebKit2/UIProcess/efl/WebView.cpp:54
> +    // Can be closed already from outside the class.

This comments does not add enough information to be useful.
You should either remove the comment, or full explain the events that leads to
such situation.

> Tools/WebKitTestRunner/efl/main.cpp:52
> +	   // Prefer the not installed web and plugin processes.


More information about the webkit-reviews mailing list