[webkit-reviews] review granted: [Bug 109436] [chromium] move printPage() implementation to testRunner library : [Attachment 187571] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 10:37:07 PST 2013


Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 109436: [chromium] move printPage() implementation to testRunner library
https://bugs.webkit.org/show_bug.cgi?id=109436

Attachment 187571: Patch
https://bugs.webkit.org/attachment.cgi?id=187571&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187571&action=review


> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1336
>  void WebViewHost::printPage(WebKit::WebFrame* frame)

Should we add an ASSERT_NOT_REACHED here?


More information about the webkit-reviews mailing list