[webkit-reviews] review denied: [Bug 105285] Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code : [Attachment 187558] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 105285: Web Inspector: [Styles] Implement navigation to UI locations of
property names/values in the source code
https://bugs.webkit.org/show_bug.cgi?id=105285

Attachment 187558: Patch
https://bugs.webkit.org/attachment.cgi?id=187558&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187558&action=review


Also missing tests.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2156
> +	       this._setLineEndingsForURL(this.style.parentRule.sourceURL,
lineEndings);

I don't think this belongs to the styles sidebar pane. It should probably be a
part of the model. This mapping should be properly encapsulated.