[webkit-reviews] review granted: [Bug 109433] Web Inspector: WebInspector.Project refactorings. : [Attachment 187568] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 07:33:00 PST 2013


Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 109433: Web Inspector: WebInspector.Project refactorings.
https://bugs.webkit.org/show_bug.cgi?id=109433

Attachment 187568: Patch
https://bugs.webkit.org/attachment.cgi?id=187568&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187568&action=review


> Source/WebCore/ChangeLog:11
> +	   Added Project.displayName() method that is delegated to project
delegate..

Duplicate trailing .

> Source/WebCore/inspector/front-end/UISourceCode.js:106
> +	   return this._path; 

Trailing whitespace

> Source/WebCore/inspector/front-end/Workspace.js:166
> +    type: function() 

Trailing whitespace

> Source/WebCore/inspector/front-end/Workspace.js:223
> +	   return this._uiSourceCodes[path];

return ... || null; for the @return type conformance.


More information about the webkit-reviews mailing list