[webkit-reviews] review granted: [Bug 107820] [EFL][WK2] Use C API inside ewk_settings : [Attachment 187477] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 107820: [EFL][WK2] Use C API inside ewk_settings
https://bugs.webkit.org/show_bug.cgi?id=107820

Attachment 187477: Patch
https://bugs.webkit.org/attachment.cgi?id=187477&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187477&action=review


> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:241
> -    , m_settings(EwkSettings::create(this))
> +    ,
m_settings(EwkSettings::create(WKPageGroupGetPreferences(WKPageGetPageGroup(wkP
age()))))

LGTM, but let's fix the dependencies first in your other patch before we go
ahead.
Then you can fix this line and land.