[webkit-reviews] review granted: [Bug 109380] [Chromium] FilterTypeSaturatingBrightness enum : [Attachment 187485] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 10 17:57:01 PST 2013


James Robinson <jamesr at chromium.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 109380: [Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380

Attachment 187485: Patch
https://bugs.webkit.org/attachment.cgi?id=187485&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187485&action=review


> Source/Platform/chromium/public/WebFilterOperation.h:52
> +	   FilterTypeSaturatingBrightness, // Legacy brightness implementation
used by internal clients

I'm not sure this comment adds any value in isolation. Perhaps specify that
it's not one in CSS/SVG if that's the distinguishing factor?


More information about the webkit-reviews mailing list