[webkit-reviews] review denied: [Bug 109317] REGRESSION (r132422): Page content and scrollbars are incorrectly offset after restoring a page from the page cache : [Attachment 187471] with a test

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 109317: REGRESSION (r132422): Page content and scrollbars are incorrectly
offset after restoring a page from the page cache
https://bugs.webkit.org/show_bug.cgi?id=109317

Attachment 187471: with a test
https://bugs.webkit.org/attachment.cgi?id=187471&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187471&action=review


>
LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-c
ache-restoration.html:22
> +	       window.open("resources/scroll-and-load-page.html");

Do you need to use window.open? Can't you just scroll, load another page that
goes back, then finish the test?

> Tools/ChangeLog:9
> +	   WebKitTestRunner should propagate window creation options to
subwindows (so that children of tiled-drawing windows use tiled drawing, in
this case).

This should really be a separate patch.

> Tools/WebKitTestRunner/PlatformWebView.h:98
> +    WKDictionaryRef options() { return m_options.get(); }

const?