[webkit-reviews] review granted: [Bug 108978] Make TestWebKitAPI work for iOS : [Attachment 187365] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 108978: Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978

Attachment 187365: Patch
https://bugs.webkit.org/attachment.cgi?id=187365&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187365&action=review


r=me!

>>>> Source/WebCore/WebCore.exp.in:2709
>>>> +__ZNK7WebCore4KURL7hasPathEv
>>> 
>>> Again, how can we export a method that's defined in a header file?	I don't
understand why this works.
>>> 
>>> Is USE(WTFURL) turned on for any port yet (Benjamin)?
>> 
>> I think it’s because:
>> 
>> WebCore/platform/KURL.cpp:
>> 73 #if !USE(GOOGLEURL) && !USE(WTFURL)
>> ...
>> 566 bool KURL::hasPath() const
>> ...
>> 663 #endif(In reply to comment #11)
> 
> WebCore/platform/KURL.h:
> 335 #if !USE(GOOGLEURL) && !USE(WTFURL)
> various is/has methods inlined here
> 
> WebCore/platform/KURL.cpp:
> 73 #if !USE(GOOGLEURL) && !USE(WTFURL)
> ...
> 566 bool KURL::hasPath() const

I understand now.  I had difficulty comparing the logic between KURL.h and
WebCore.exp.in (trying to compare positive logic with negative logic).