[webkit-reviews] review granted: [Bug 108549] Add platform support for -webkit-background-blend-mode to CG context : [Attachment 187402] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 108549: Add platform support for -webkit-background-blend-mode to CG
context
https://bugs.webkit.org/show_bug.cgi?id=108549

Attachment 187402: Patch
https://bugs.webkit.org/attachment.cgi?id=187402&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187402&action=review


r+ with comments, and some tests to skip.

> Source/WebCore/platform/graphics/GraphicsContext.h:409
> +	   BlendMode blendModeOperation() const;

It's a shame we have to append Operation here. Oh well.

> LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html:29
> +<li style="-webkit-box-reflect:below 5px -webkit-gradient(linear, left top,
left bottom, from(transparent), color-stop(0.5, transparent),
to(white));"></li>

You should use the unprefixed linear-gradient, like you did above.

> LayoutTests/css3/compositing/effect-background-blend-mode.html:16
> +	background:  url("resources/ducky.png") no-repeat 0 0 /100% 100%,
linear-gradient(to right, #00ffff 0%, rgba(0,0,255,0) 24%, #ff0000 50%, #ffff00
75%, #00ff00 100%);

Do we have the rights to this ducky image?