[webkit-reviews] review denied: [Bug 106358] [EFL][WebGL] WebGL content is not painted after resizing the viewport. : [Attachment 186075] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 106358: [EFL][WebGL] WebGL content is not painted after resizing the
viewport.
https://bugs.webkit.org/show_bug.cgi?id=106358

Attachment 186075: Patch
https://bugs.webkit.org/attachment.cgi?id=186075&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186075&action=review


I'd rather not add a test at all than add a flaky test.

> Source/WebCore/ChangeLog:9
> +	   When page size changes and layer parameters get updated
LayerTreeRenderer::setLayerState
> +	   clears layer backing store and detaches canvas surface from the
layer. If layer size is

You're missing "the"s
clears the layer backing store and detaches the canvas surface. If the layer
size

> Source/WebCore/ChangeLog:10
> +	   not changed then canvas recreate is not invoked because canvas size
is also not changed

then the canvas is not recreated. This leaves the canvas detached from the
layer, but still referenced from m_surfaceBackingStores.

> Source/WebCore/ChangeLog:12
> +	   Don't assign layer backing store to layer in
assignImageBackingToLayer if there is canvas

if there is a canvas surface

> LayoutTests/ChangeLog:10
> +	   Add test checking that canvas painting is correct if layer
parameters were changed,
> +	   but webgl canvas didn't change.
> +

This is not a good description of the test. Please explain why you need a test
with 3 canvases just to reproduce this.