[webkit-reviews] review denied: [Bug 108610] [TexMap] Remove Animation in GraphicsLayerAnimation. : [Attachment 187211] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Chang Wan Hong
<jourmoon at company100.net>'s request for review:
Bug 108610: [TexMap] Remove Animation in GraphicsLayerAnimation.
https://bugs.webkit.org/show_bug.cgi?id=108610

Attachment 187211: Patch
https://bugs.webkit.org/attachment.cgi?id=187211&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187211&action=review


> Source/WebCore/ChangeLog:10
> +	   GraphicsLayerAnimation uses Animation just for some members. It is
more
> +	   succinct to have the internal type for this purpose. Extracting some
members
> +	   from Animation, I create GraphicsLayerAnimation::Animation.

"More succinct" is not a good enough argument for this patch... We're
duplicating several things from WebCore::Animation, like fillsForwards() etc.
We need a better argument for this.

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp:156
> +GraphicsLayerAnimation::GraphicsLayerAnimation(const String& name, const
KeyframeValueList& keyframes, const IntSize& boxSize, const Attributes&
animAttrs, double startTime, bool listsMatch)

animAttr -> attributes

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.h:55
> +	   Attributes(unsigned _direction, double _duration, double
_iterationCount, double _fillMode, PassRefPtr<TimingFunction> _timingFunction)

Don't use _ please... 
: direction(direction) should be ok, also : direction(newDirection).

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.h:91
> +    Attributes attributes() const { return m_attributes; }

const Attributes& attributes() const

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:614
> +    m_animations.add(GraphicsLayerAnimation(keyframesName, valueList,
boxSize, animAttrs, WTF::currentTime() - timeOffset, listsMatch));

animAttr -> attributes

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:1027
> +    const GraphicsLayerAnimation::Attributes animAttrs(anim->direction(),
anim->duration(), anim->iterationCount(), anim->fillMode(),
anim->timingFunction());

No need for const.

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:1029
> +    m_animations.add(GraphicsLayerAnimation(keyframesName, valueList,
boxSize, animAttrs, m_lastAnimationStartTime, listsMatch));

Ditto

>
Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
:749
> +    const GraphicsLayerAnimation::Attributes animAttrs(direction, duration,
iterationCount, fillMode, timingFunction);

No need for const.