[webkit-reviews] review denied: [Bug 109308] Web Inspector: Add command for selecting files for file input element : [Attachment 187334] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 9 02:01:33 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Ken Kania
<kkania at chromium.org>'s request for review:
Bug 109308: Web Inspector: Add command for selecting files for file input
element
https://bugs.webkit.org/show_bug.cgi?id=109308

Attachment 187334: Patch
https://bugs.webkit.org/attachment.cgi?id=187334&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187334&action=review


> Source/WebCore/inspector/Inspector.json:2106
> +		   "name": "setFileInputFiles",

I am not sure this fits DOM domain well, but I have no better idea.

> LayoutTests/inspector-protocol/dom-focus.html:-6
> -window.addEventListener("load", function() {

Please move these in a separate change.


More information about the webkit-reviews mailing list