[webkit-reviews] review granted: [Bug 109345] Create the SharedGraphicsContext3D through its own method. : [Attachment 187416] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 22:51:16 PST 2013


James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 109345: Create the SharedGraphicsContext3D through its own method.
https://bugs.webkit.org/show_bug.cgi?id=109345

Attachment 187416: Patch
https://bugs.webkit.org/attachment.cgi?id=187416&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187416&action=review


R=me but needs an if

> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:75
> +	   m_context =
GraphicsContext3DPrivate::createGraphicsContextFromWebContext(webContext.releas
e(), false);

i don't think this call is safe to do if webContext is null


More information about the webkit-reviews mailing list