[webkit-reviews] review granted: [Bug 109203] [Mac] respect in-band caption color : [Attachment 187406] Updated patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 109203: [Mac] respect in-band caption color
https://bugs.webkit.org/show_bug.cgi?id=109203

Attachment 187406: Updated patch
https://bugs.webkit.org/attachment.cgi?id=187406&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187406&action=review


> Source/WebCore/ChangeLog:10
> +	   * WebCore.xcodeproj/project.pbxproj:

Probably should mention you exported HTMLDivElement. Actually, why do you do
this?

> LayoutTests/media/track/track-in-band-style-expected.txt:14
> +EXPECTED (getComputedStyle(cueDisplayElement).color == 'rgb(255, 255, 255)')
OK
> +EXPECTED (getComputedStyle(cueNode).backgroundColor == 'rgb(0, 0, 0)') OK

Are these actually set in counting-captioned.mov? I'm wondering what the
default values would be, and whether this test would pass on any captioned
movie that doesn't set the style.