[webkit-reviews] review granted: [Bug 108414] DFG should allow phases to break Phi's and then have one phase to rebuild them : [Attachment 187387] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 18:17:44 PST 2013


Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 108414: DFG should allow phases to break Phi's and then have one phase to
rebuild them
https://bugs.webkit.org/show_bug.cgi?id=108414

Attachment 187387: the patch
https://bugs.webkit.org/attachment.cgi?id=187387&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187387&action=review


r=me. Just for due diligence, what's the performance numbers for this
currently?

> Source/JavaScriptCore/dfg/DFGCPSRethreadingPhase.cpp:342
> +	       // following from from predecessor blocks: SetLocal, Phi, or
SetArgument.

from from

> Source/JavaScriptCore/dfg/DFGGraph.h:-83
> -    

Stray whitespace.


More information about the webkit-reviews mailing list