[webkit-reviews] review denied: [Bug 109285] [Curl] setCookiesFromDOM function does not save cookies to disk. : [Attachment 187292] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 09:14:50 PST 2013

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
Bug 109285: [Curl] setCookiesFromDOM function does not save cookies to disk.

Attachment 187292: Patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187292&action=review

Very nice update.  Please switch to an "early return" style for that one
method, since no other actions are taken in the case where the CURL handle is

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:37
> +    if (curl) {

Please make this an early return, since we do nothing if the curl interface is
not present.

More information about the webkit-reviews mailing list