[webkit-reviews] review denied: [Bug 109285] [Curl] setCookiesFromDOM function does not save cookies to disk. : [Attachment 187292] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 109285: [Curl] setCookiesFromDOM function does not save cookies to disk.
https://bugs.webkit.org/show_bug.cgi?id=109285

Attachment 187292: Patch
https://bugs.webkit.org/attachment.cgi?id=187292&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187292&action=review


Very nice update.  Please switch to an "early return" style for that one
method, since no other actions are taken in the case where the CURL handle is
null.

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:37
> +    if (curl) {

Please make this an early return, since we do nothing if the curl interface is
not present.