[webkit-reviews] review denied: [Bug 99241] StyleSheetList should be a ContextDestructionObserver : [Attachment 187234] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Hanyee Kim <choco at company100.net>'s
request for review:
Bug 99241: StyleSheetList should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=99241

Attachment 187234: Patch
https://bugs.webkit.org/attachment.cgi?id=187234&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187234&action=review


> Source/WebCore/css/StyleSheetList.cpp:61
> +void StyleSheetList::contextDestroyed()
> +{
> +    m_detachedStyleSheets =
document()->styleSheetCollection()->styleSheetsForStyleSheetList();
>  }

You need to call the base class here otherwise ContextDestructionObserver's
pointer won't be cleared.

Also, is it ok to call
document()->styleSheetCollection()->styleSheetsForStyleSheetList() at this
point in the Document's destructor?  Your patch might have moved when this
happens slightly.