[webkit-reviews] review denied: [Bug 99241] StyleSheetList should be a ContextDestructionObserver : [Attachment 187234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 08:45:39 PST 2013

Adam Barth <abarth at webkit.org> has denied Hanyee Kim <choco at company100.net>'s
request for review:
Bug 99241: StyleSheetList should be a ContextDestructionObserver

Attachment 187234: Patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187234&action=review

> Source/WebCore/css/StyleSheetList.cpp:61
> +void StyleSheetList::contextDestroyed()
> +{
> +    m_detachedStyleSheets =
>  }

You need to call the base class here otherwise ContextDestructionObserver's
pointer won't be cleared.

Also, is it ok to call
document()->styleSheetCollection()->styleSheetsForStyleSheetList() at this
point in the Document's destructor?  Your patch might have moved when this
happens slightly.

More information about the webkit-reviews mailing list