[webkit-reviews] review denied: [Bug 109180] [GTK][Introspection] GObject bindings for DataTransferItemList - one add() method must be removed from .idl : [Attachment 187263] Disabled the add(File) function in CodeGeneratorGObject.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 06:21:32 PST 2013


Xan Lopez <xan.lopez at gmail.com> has denied Tomas Popela <tpopela at redhat.com>'s
request for review:
Bug 109180: [GTK][Introspection] GObject bindings for DataTransferItemList -
one add() method must be removed from .idl
https://bugs.webkit.org/show_bug.cgi?id=109180

Attachment 187263: Disabled the add(File) function in CodeGeneratorGObject.pm
https://bugs.webkit.org/attachment.cgi?id=187263&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
As Zan says I think 'add' is too generic to skip it merely by its name, so we
should expand the method to check for the interface name and only do this for
the DataTransferItemList case.


More information about the webkit-reviews mailing list