[webkit-reviews] review denied: [Bug 109286] Web Inspector: Avoid using offsetWidth/offsetHeight in SplitView : [Attachment 187290] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 8 04:55:20 PST 2013
Pavel Feldman <pfeldman at chromium.org> has denied review:
Bug 109286: Web Inspector: Avoid using offsetWidth/offsetHeight in SplitView
https://bugs.webkit.org/show_bug.cgi?id=109286
Attachment 187290: Patch
https://bugs.webkit.org/attachment.cgi?id=187290&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187290&action=review
> Source/WebCore/inspector/front-end/SplitView.js:-295
> - var resizerWidth = this._resizerElement.offsetWidth;
Why making resize 0-width? You should simply cache the value or calculate it
before you damage layout in _removeAllLayoutProperties above.
More information about the webkit-reviews
mailing list