[webkit-reviews] review granted: [Bug 109282] Web Inspector: Introduce workspace provider/project type, encapsulate uri creation in SimpleWorkspaceProvider. : [Attachment 187285] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 04:38:25 PST 2013


Alexander Pavlov (apavlov) <apavlov at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 109282: Web Inspector: Introduce workspace provider/project type,
encapsulate uri creation in SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=109282

Attachment 187285: Patch
https://bugs.webkit.org/attachment.cgi?id=187285&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187285&action=review


> Source/WebCore/ChangeLog:11
> +	   Drive-by: ScriptsPanel now uses FileMApping to show anchor location
properly.

FileMapping

> Source/WebCore/inspector/front-end/SimpleWorkspaceProvider.js:141
> +

odd line

> Source/WebCore/inspector/front-end/Workspace.js:337
> +		   result = result.concat(project.uiSourceCodes());

result.push.apply(result, project.uiSourceCodes());


More information about the webkit-reviews mailing list