[webkit-reviews] review granted: [Bug 109141] Web Inspector: [Resources] Prefactorings in DataGrid and CookieTable : [Attachment 187005] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 23:44:22 PST 2013

Pavel Feldman <pfeldman at chromium.org> has granted Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 109141: Web Inspector: [Resources] Prefactorings in DataGrid and

Attachment 187005: Patch

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187005&action=review

looks good with a nit.

> Source/WebCore/inspector/front-end/CookieParser.js:358
> +WebInspector.Cookie.deleteCookie = function(cookie)

just declare it as "delete" on the WebInspector.Cookie.prototype. Also please
add an optional callback.

More information about the webkit-reviews mailing list