[webkit-reviews] review granted: [Bug 107034] Get Windows test infrastructure to compile on VS2010 (32 bit) : [Attachment 187199] DRT and related projects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 21:48:27 PST 2013


Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 107034: Get Windows test infrastructure to compile on VS2010 (32 bit)
https://bugs.webkit.org/show_bug.cgi?id=107034

Attachment 187199: DRT and related projects
https://bugs.webkit.org/attachment.cgi?id=187199&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187199&action=review


Looks great! I think you want to lose the *.users (and probably elsewhere in
all the VS2010 stuff we've been playing with),

Also, I had a question about a file you deleted, that I hoped you could clarify
in your ChangeLog entry.

Thanks!

> Source/WebCore/ChangeLog:10
> +	   * WebCore.vcxproj/WebCoreTestSupport.vcxproj.user: Added.

I'm not sure we want to be checking in *.user files. I think it only contains
user-specific stuff like break points and other stuff.

We should probably have them added to svn:ignore.

> Source/WebCore/WebCore.vcxproj/WebCoreTestSupport.vcxproj:52
> +	 <DisableSpecificWarnings
Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">4065;4273;4565;4701;4
702;%(DisableSpecificWarnings)</DisableSpecificWarnings>

All of these targets use the same disabled warnings:  to the props file,
please!

> Source/WebCore/WebCore.vcxproj/WebCoreTestSupport.vcxproj.user:3
> +</Project>

I don't think we ever want to add these to source control.

> Tools/ChangeLog:17
> +	   *
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcx
proj.user: Added.

Ditto my user comments from elsewhere.

> Tools/ChangeLog:30
> +	   *
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj.user:
Added.

Ditto

> Tools/ChangeLog:42
> +	   *
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcx
proj.user: Added.

Ditto.

> Tools/ChangeLog:48
> +	   *
DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Removed.

Why is this being deleted? Could you add a note, like maybe it's not used
anymore or something?

>
Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxpr
oj.user:3
> +</Project>

Delete please.

>
Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLaunch
er.vcxproj.user:4
> +   
<LocalDebuggerCommandArguments>C:\cygwin\home\Roger\WebKit\OpenSource\LayoutTes
ts\fast\js\kde</LocalDebuggerCommandArguments>

See! I don't want that for my build! :)

Delete from checking, please!

>
Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj.user:3
> +</Project>

Delete this.

>
Tools/DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj
.user:3
> +</Project>

Delete please.

>
Tools/DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlug
in.vcxproj.user:3
> +</Project>

Deletr


More information about the webkit-reviews mailing list