[webkit-reviews] review granted: [Bug 109221] build-webkit: document sdk, debug, release, device, and simulator options : [Attachment 187159] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 109221: build-webkit: document sdk, debug, release, device, and simulator
options
https://bugs.webkit.org/show_bug.cgi?id=109221

Attachment 187159: Patch
https://bugs.webkit.org/attachment.cgi?id=187159&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187159&action=review


r=me with those changes.

> Tools/Scripts/build-webkit:112
> -  --debug			       Compile in debug mode
> +  --debug			       Compile with Debug Xcode configuration
> +  --release			       Compile with Release Xcode configuration


The --debug (and --release) switches are used by more than just platforms that
build with Xcode.

I would suggest removing "Xcode" from the help text here.

> Tools/Scripts/build-webkit:113
> +  --sdk=<sdk>		       Use a specific Xcode SDK

I would add "(iOS and Mac only)" to the end of the description here.

> Tools/Scripts/build-webkit:115
> +  --device			       Use the iphoneos.internal SDK
> +  --simulator		       Use the iphonesimulator SDK

Similarly, add "(iOS only)" here.  Maybe:

Use the current <sdkname> SDK (iOS only)