[webkit-reviews] review denied: [Bug 108670] [V8] IndexedDB: Minor GC can collect IDBDatabase wrapper with versionchange handler : [Attachment 187201] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 108670: [V8] IndexedDB: Minor GC can collect IDBDatabase wrapper with
versionchange handler
https://bugs.webkit.org/show_bug.cgi?id=108670

Attachment 187201: Patch
https://bugs.webkit.org/attachment.cgi?id=187201&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187201&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests - TODO before landing.

Yeah, a test case please. You can write a reliable test case by using gc(),
which explicitly triggers full garbage collection.

> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:362
> +    // FIXME: Only keep the wrapper alive if there are event listeners.

Is it difficult to check whether event listeners are attached or not?

> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:363
> +    return !m_closePending || ActiveDOMObject::hasPendingActivity();

Why do you need ActiveDOMObject::hasPendingActivity() ?