[webkit-reviews] review denied: [Bug 109220] [Chromium] Fix use after free in ContextMenuClientImpl.cpp : [Attachment 187154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 15:50:57 PST 2013


Tony Chang <tony at chromium.org> has denied Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 109220: [Chromium] Fix use after free in ContextMenuClientImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=109220

Attachment 187154: Patch
https://bugs.webkit.org/attachment.cgi?id=187154&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187154&action=review


> Source/WebKit/chromium/ChangeLog:8
> +
> +	   * src/ContextMenuClientImpl.cpp:

Please provide more information here.  At a minimum, how people are triggering
the crash and why this is the right fix.  It's not clear to me why this would
fix a crash.  It would also be OK to link to the chromium bug.

Do you know if this is a recent regression?  It would be nice to know when this
crash was introduced.


More information about the webkit-reviews mailing list