[webkit-reviews] review granted: [Bug 107863] Makefiles should work for arbitrary SDKs and architectures on Apple ports : [Attachment 187147] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 107863: Makefiles should work for arbitrary SDKs and architectures on Apple
ports
https://bugs.webkit.org/show_bug.cgi?id=107863

Attachment 187147: Patch
https://bugs.webkit.org/attachment.cgi?id=187147&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187147&action=review


This looks good to go. You should see if it's possible to remove the leading
spaces as mentioned above. If it's not, let me know and I can cq+ this patch.
If it is, upload a new patch and I'll r+ and cq+ it instead.

> Makefile.shared:11
> +	XCODE_OPTIONS += " ARCHS=$(ARCHS)"
> +	XCODE_OPTIONS += " ONLY_ACTIVE_ARCH=NO"