[webkit-reviews] review granted: [Bug 107838] Objective-C API: testapi.mm should use ARC : [Attachment 187177] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 14:36:45 PST 2013


Mark Rowe (bdash) <mrowe at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 107838: Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Attachment 187177: Patch
https://bugs.webkit.org/attachment.cgi?id=187177&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=187177&action=review


r=me with those changes.  Thanks for cleaning this up!

> Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:36
> +CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH))

This should have a trailing ; for consistency.

> Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:39
> +CLANG_ENABLE_OBJC_ARC_ = NO;
> +CLANG_ENABLE_OBJC_ARC_i386 = NO;
> +CLANG_ENABLE_OBJC_ARC_ppc = NO;

Since ARC defaults to off, you can omit all of these lines that explicitly set
it to NO.


More information about the webkit-reviews mailing list