[webkit-reviews] review granted: [Bug 71851] Implement script MIME restrictions for X-Content-Type-Options: nosniff : [Attachment 187027] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 10:56:18 PST 2013


Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 71851: Implement script MIME restrictions for X-Content-Type-Options:
nosniff
https://bugs.webkit.org/show_bug.cgi?id=71851

Attachment 187027: Patch
https://bugs.webkit.org/attachment.cgi?id=187027&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187027&action=review


The change LGTM, but can we wait until Tuesday to land it?  That means it will
have a full Dev channel cycle to catch compat problems before being promoted to
the Beta channel.

> Source/WebCore/loader/cache/CachedScript.cpp:134
> +	   return false;
> +    return true;

There's no need to use an if statement.  You can just return the Boolean value
directly.


More information about the webkit-reviews mailing list