[webkit-reviews] review denied: [Bug 107820] [EFL][WK2] Use C API inside ewk_settings : [Attachment 184529] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 10:49:59 PST 2013

Anders Carlsson <andersca at apple.com> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 107820: [EFL][WK2] Use C API inside ewk_settings

Attachment 184529: Patch

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=184529&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_settings_private.h:49
>> +	inline WKPreferencesRef preferences();
> would prefer having method definition here (it's just 1 line), that would
make it inline automatically.

Putting inline on a member function that is not defined in its header file (or
a header file) is weird. Please either remove the inline or make the function
actually be inline.

More information about the webkit-reviews mailing list