[webkit-reviews] review denied: [Bug 109155] Remove V8 specific code from CustomEvent : [Attachment 187024] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 109155: Remove V8 specific code from CustomEvent
https://bugs.webkit.org/show_bug.cgi?id=109155

Attachment 187024: Patch
https://bugs.webkit.org/attachment.cgi?id=187024&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187024&action=review


> Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:48
> -    unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable,
serializedScriptValue.get());
> +    unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable,
serializedScriptValue->deserialize());

The problem is that this won't work correctly with isolated worlds.  When you
deserialize the object, you lock it to a given world.  The existing code
deserializes it once per world so that each world see a different instance of
the object with the correct prototypes.