[webkit-reviews] review denied: [Bug 109177] Event::setTarget() and Event::setRelatedTarget() should receive a PassRefPtr : [Attachment 187062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 09:33:48 PST 2013


Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 109177: Event::setTarget() and Event::setRelatedTarget() should receive a
PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=109177

Attachment 187062: Patch
https://bugs.webkit.org/attachment.cgi?id=187062&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
There is no rationale, and I think that this change is incorrect. PassRefPtr is
a performance optimization to be used when passing ownership, which is not the
case here.


More information about the webkit-reviews mailing list