[webkit-reviews] review denied: [Bug 109183] Web Inspector: breakpoint condition not editable : [Attachment 187089] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 109183: Web Inspector: breakpoint condition not editable
https://bugs.webkit.org/show_bug.cgi?id=109183

Attachment 187089: Patch
https://bugs.webkit.org/attachment.cgi?id=187089&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187089&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2096
> +	   for(var i = 0; i < this._decorationElements; ++i) {

Traversing all decorations element seems not quite efficient.
You can tyr using the fact that all decorations are stored in the div with
"webkit-line-decorations" class.