[webkit-reviews] review granted: [Bug 107552] Web Inspector: Show elements and sources sidebar panes in a tabbed pane when they are below the main pane : [Attachment 187067] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 107552: Web Inspector: Show elements and sources sidebar panes in a tabbed
pane when they are below the main pane
https://bugs.webkit.org/show_bug.cgi?id=107552

Attachment 187067: Patch
https://bugs.webkit.org/attachment.cgi?id=187067&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187067&action=review


> Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js:384
> +    onContentReady: function ()

Remove space before ()

> Source/WebCore/inspector/front-end/ElementsPanel.js:85
> +    this.sidebarPanes.domBreakpoints = new
WebInspector.DOMBreakpointsSidebarPane.Proxy(WebInspector.domBreakpointsSidebar
Pane, this);

Factory would look better on the call sites.