[webkit-reviews] review denied: [Bug 107461] [Qt] QtTestBrowser should provide option to enable/disable Javascript : [Attachment 183888] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Vivek Galatage
<vivek.vg at samsung.com>'s request for review:
Bug 107461: [Qt] QtTestBrowser should provide option to enable/disable
Javascript
https://bugs.webkit.org/show_bug.cgi?id=107461

Attachment 183888: Patch
https://bugs.webkit.org/attachment.cgi?id=183888&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183888&action=review


> Tools/QtTestBrowser/launcherwindow.cpp:501
> +    toggleJavaScriptEnabled->setChecked(true);

This should read:
toggleJavaScriptEnabled->setChecked(settings->testAttribute(QWebSettings::Javas
criptEnabled));

> Tools/QtTestBrowser/launcherwindow.cpp:933
> +    statusBar()->showMessage(QString("Javascript ") + QString(enable ?
"enabled" : "disabled"), 5000);

This isn't necessary, the checkbox already tells the user if JS is enabled or
not.