[webkit-reviews] review granted: [Bug 107937] Web Inspector: CPU pegged when inspecting LocalStorage that mutates. : [Attachment 186588] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vivek Galatage
<vivek.vg at samsung.com>'s request for review:
Bug 107937: Web Inspector: CPU pegged when inspecting LocalStorage that
mutates.
https://bugs.webkit.org/show_bug.cgi?id=107937

Attachment 186588: Patch
https://bugs.webkit.org/attachment.cgi?id=186588&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186588&action=review


> Source/WebCore/inspector/Inspector.json:1500
> +		       { "name": "oldValue", "type": "string" },

oldValue and newValue should be optional as they makes sense not for all
actions. Even key param should be optional as there is no key for itemsCleared.
Vsevolod's suggestion to split the event into 4 would eliminate the problem.

> Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:238
> +    if (key.isEmpty() && key.isNull())

isNull implies isEmpty

> Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:240
> +    else if (newValue.isEmpty() && newValue.isNull())

ditto

> Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:242
> +    else if (oldValue.isEmpty() && oldValue.isNull())

ditto