[webkit-reviews] review denied: [Bug 107552] Web Inspector: Show elements and sources sidebar panes in a tabbed pane when they are below the main pane : [Attachment 187018] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 107552: Web Inspector: Show elements and sources sidebar panes in a tabbed
pane when they are below the main pane
https://bugs.webkit.org/show_bug.cgi?id=107552

Attachment 187018: Patch
https://bugs.webkit.org/attachment.cgi?id=187018&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=187018&action=review


> Source/WebCore/inspector/front-end/SidebarPane.js:141
> +	   this.attachPane(index);

just inline this._panes.length

> Source/WebCore/inspector/front-end/SidebarPane.js:147
> +    attachPane: function(index)

What exactly does this method do?

> Source/WebCore/inspector/front-end/SidebarPane.js:152
> +	   pane.setExpandCallback(this._onPaneExpanded.bind(this, index));

Why does it need expanded callback?