[webkit-reviews] review granted: [Bug 108824] Web Inspector: Native Memory Instrumentation: reduce native heap snapshot runtime memory footprint : [Attachment 186863] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 108824: Web Inspector: Native Memory Instrumentation: reduce native heap
snapshot runtime memory footprint
https://bugs.webkit.org/show_bug.cgi?id=108824

Attachment 186863: Patch
https://bugs.webkit.org/attachment.cgi?id=186863&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186863&action=review


> Source/WebCore/inspector/HeapGraphSerializer.cpp:70
> +void HeapGraphSerializer::pushUpdateIfNeed()

pushUpdateIfNeed ->  pushUpdateIfNeeded

> Source/WebCore/inspector/HeapGraphSerializer.cpp:169
> +    info.addMember(m_baseToRealNodeIdMap, "nodeIdRemapping");

nodeIdRemapping -> baseToRealNodeIdMap

> Source/WebCore/inspector/HeapGraphSerializer.h:94
> +    static const size_t s_remappingFieldsCount = 2;

s_idMapEntryFieldCount ?

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:335
> +	       nodeId2NodeIndex[this._nodes[i]] = i - nodeIdFieldOffset;

shift 4 spaces to the right