[webkit-reviews] review denied: [Bug 108899] Coordinated Graphics : Refactor CoordinatedSurface to prepare for WebKit1 CoordinatedSurface : [Attachment 186539] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Jae Hyun Park
<jae.park at company100.net>'s request for review:
Bug 108899: Coordinated Graphics : Refactor CoordinatedSurface to prepare for
WebKit1 CoordinatedSurface
https://bugs.webkit.org/show_bug.cgi?id=108899

Attachment 186539: Patch
https://bugs.webkit.org/attachment.cgi?id=186539&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186539&action=review


> Source/WebCore/ChangeLog:20
> +	   1. It introduces CoordinatedGraphics::GraphicsContextHolder. Other
> +	   classes access GraphicsContext via GraphicsContextHolder, instead of

> +	   accessing GraphicsContext directly.
> +
> +	   WebKit1 CoordinatedSurface will be implemented using GraphicsSurface
and
> +	   ImageBuffer. ImageBuffer owns GraphicsContext itself and cannot pass
its
> +	   OwnPtr. Therefore, this patch refactors CoordinatedSurface to pass
> +	   GraphicsContextHolder, and make other classes access GraphicsContext
via
> +	   GraphicsContextHolder.

This part doesn't make sense to me; Why not, instead, use explicit beginPaint
that returns GraphicsContext* and endPaint?
We should find a more readable solution than the "holder" pattern...