[webkit-reviews] review denied: [Bug 107942] [texmap] Implement frames-per-second debug counter : [Attachment 186992] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 107942: [texmap] Implement frames-per-second debug counter
https://bugs.webkit.org/show_bug.cgi?id=107942

Attachment 186992: Patch
https://bugs.webkit.org/attachment.cgi?id=186992&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=186992&action=review


This is not a good way to show FPS :)
Drawing text in every frame into a buffer and then uploading that buffer is
very inefficient, and would probably result in reduced FPS.
I think this should be part of WebInspector.

> Source/WebCore/ChangeLog:8
> +	   Added TextureMapper' FPS counter via WEBKIT_SHOW_FPS=<interval>
envvar,

Spell out envvar -> environment variable

> Source/WebCore/ChangeLog:12
> +	   Visual debugging feature, no need to tests.

no need to tests -> no need for new testes

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:92
> +    // FIXME: Using drawRepaintCounter() from TextureMapper.

Why is that a FIXME?

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cp
p:88
> +    if (ok && m_fpsInterval) {

Early return please

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cp
p:91
> +	   if (layer) {

In which case would layer equal false?